Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: side drawer 'Find out more...' content #305

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

zz-hh-aa
Copy link
Collaborator

@zz-hh-aa zz-hh-aa commented Jan 28, 2025

What's new in this PR

  • Installs react-markdown
  • New directory Dashboard/Help/ that stores the drawer content in markdown files, named identically to the cards themselves
  • Updates the cards to use the markdown content
    • Some of the cards use string processing and .replace() in order to not hard-code variables
  • I also had to move a tiny bit of math out of a constant and into the Lifetime class

Why

  • Maintaining separate markdown files with the side drawer content in is easier than dealing with HTML tags etc., thanks to Daf for pattern suggestion

Questions

❓ Is there a tidier way of going about rendering Markdown in the drawer?
❓ Most of this PR is Markdown (which is why there are so many lines), should it be split up into a few smaller ones?

@zz-hh-aa zz-hh-aa requested a review from a team January 28, 2025 16:41
@zz-hh-aa zz-hh-aa marked this pull request as ready for review January 28, 2025 16:41
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 9:53am

@zz-hh-aa
Copy link
Collaborator Author

zz-hh-aa commented Jan 29, 2025

❗ Note to self to update the NHS save help text after the chain of #308, #307 and #300 merges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant