Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: social value calculations #297

Merged
merged 7 commits into from
Jan 27, 2025
Merged

feat: social value calculations #297

merged 7 commits into from
Jan 27, 2025

Conversation

zz-hh-aa
Copy link
Collaborator

  • Creates a new SocialValue class within Household (and associated tests)
  • Renders SocialValue figures in the WhatDifference card

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:13am

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few question or nitpicks, but all good 👌

app/models/constants.ts Outdated Show resolved Hide resolved
app/models/SocialValue.test.ts Outdated Show resolved Hide resolved
app/models/SocialValue.ts Outdated Show resolved Hide resolved
app/models/SocialValue.ts Show resolved Hide resolved
app/models/SocialValue.ts Outdated Show resolved Hide resolved
app/models/SocialValue.ts Show resolved Hide resolved
<div className="flex flex-wrap gap-6">
<Card title="Money saved" figure="£30,000">
<p>On housing costs over 10 years, compared to conventional ownership</p>
<Card title="Money saved" figure={`£${Math.round(household.socialValue.moneySaved).toLocaleString()}`}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from oz/household-gas-object to main January 27, 2025 09:12
@zz-hh-aa zz-hh-aa merged commit d793910 into main Jan 27, 2025
5 checks passed
@zz-hh-aa zz-hh-aa deleted the oz/social-value branch January 27, 2025 10:17
@zz-hh-aa zz-hh-aa mentioned this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants