Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compare resale values over time chart #285

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Conversation

zz-hh-aa
Copy link
Collaborator

@zz-hh-aa zz-hh-aa commented Jan 15, 2025

What does this PR do?

  • New ResaleValue component allows you to toggle between the two Fairhold tenures being compared here
    • There is a new TenureSelector button component (that can be reused in 'How would the cost change over my life?' in card 3)
  • ResaleValueLineChart renders the graph and ResaleValueWrapper formats the data for both
  • Adds the graph to the Dashboard

Why

  • All as per Miro design
    image

Closes #254

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:30pm

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool! Really great to see the animations.

A few very minor comments on code 👍

app/components/Dashboard/Cards/ResaleValue.tsx Outdated Show resolved Hide resolved
app/components/Dashboard/Cards/ResaleValue.tsx Outdated Show resolved Hide resolved
app/components/Dashboard/Cards/ResaleValue.tsx Outdated Show resolved Hide resolved
app/components/graphs/ResaleValueLineChart.tsx Outdated Show resolved Hide resolved
app/components/graphs/ResaleValueLineChart.tsx Outdated Show resolved Hide resolved
app/components/graphs/ResaleValueWrapper.tsx Outdated Show resolved Hide resolved
Base automatically changed from oz/all-maintenance-levels to main January 16, 2025 14:55
@zz-hh-aa zz-hh-aa merged commit 3c1faa8 into main Jan 16, 2025
5 checks passed
@zz-hh-aa zz-hh-aa deleted the oz/resale-value-chart branch January 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create content GraphCard number 4
2 participants