solved magic number issue

theopensystemslab · Aug 26, 2024 · 456c7b1 · 456c7b1
1 parent 2e11719
commit 456c7b1
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/app/models/Mortgage.ts b/app/models/Mortgage.ts
@@ -90,13 +90,12 @@ export class Mortgage {
         remainingBalance: remainingBalance,
       },
     ];
-
+    const finalYear = this.termYears - 2;
     for (let i = 0; i < this.termYears - 1; i++) {
-      if (i != this.termYears - 2) {
-        yearlyPayment = this.monthlyPayment * MONTHS_PER_YEAR;
-      } else {
-        // last year just pay the remaining balance
+      if (i == finalYear) {
         yearlyPayment = remainingBalance;
+      } else {
+        yearlyPayment = this.monthlyPayment * MONTHS_PER_YEAR;
       }
 
       cumulativePaid = cumulativePaid + yearlyPayment;