Fix factorial2 and pytest fix #308 and #309

[D-TheProgrammer]

This pull request represents another attempt to address the issue. The previous attempt was unmergeable due to being made from the main branch. The objective of this fix is to address the issues with the factorial2 function in the òverlap.pyfile and create a unit test using pytest named test_factorial2. Our solution for the function has been validated by passing the linting checks.

[D-TheProgrammer]

@tovrstra Normally it should be good now for the merge let us know
@LudoRNLT here's the new one i forgot to tag you on this one

[tovrstra]

@D-TheProgrammer Thanks for the pull request and my apologies for the large number of changes we're going through while you were making pull requests.

There are still a few linters complaining. If you click on "Details" on the "pre-commit.ci - pr" line, and then scroll down, you will see the errors. Normally, when you install pre-commit in the clone of the repository on your computer, it will not allow you to make the commit when there are such issues. If you need help getting that to work, please let me know. (This is the recommended procedure, because fixing issues is always easier right after having written the code.)

If you need help with fixing the linter complaints themselves, just let me know.

[D-TheProgrammer]

@D-TheProgrammer Thanks for the pull request and my apologies for the large number of changes we're going through while you were making pull requests.

There are still a few linters complaining. If you click on "Details" on the "pre-commit.ci - pr" line, and then scroll down, you will see the errors. Normally, when you install pre-commit in the clone of the repository on your computer, it will not allow you to make the commit when there are such issues. If you need help getting that to work, please let me know. (This is the recommended procedure, because fixing issues is always easier right after having written the code.)

If you need help with fixing the linter complaints themselves, just let me know.

@tovrstra We tried with our computers and we had 4 or 5 linters that didn't work but they were not tied to our fix it was about the other functions outside of factorial2 but still in overlap.py, this is why we did our PR because we thought that someone else was working on those other issues.

[tovrstra]

I have another small question. I may be overlooking something, but I don't believe we need the floating point case in IOData and always need exact=True, which may be used to simplify our version of factorial2 considerably.

[tovrstra]

@tovrstra We tried with our computers and we had 4 or 5 linters that didn't work but they were not tied to our fix it was about the other functions outside of factorial2 but still in overlap.py, this is why we did our PR because we thought that someone else was working on those other issues.

Ok, sounds good. No worries. Thanks for the quick reply. I'll take care of it after the weekend

[deepsource-io]

Here's the code health analysis summary for commits 486e413..d40b543. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Shell	✅ Success		View Check ↗
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[tovrstra]

@D-TheProgrammer I made all improvements I could think of. Can you double-check the final result? Thanks.

[D-TheProgrammer]

@D-TheProgrammer I made all improvements I could think of. Can you double-check the final result? Thanks.

Normally if we're not wrong @LudoRNLT and I think it's good and it ticks all the boxes.

[tovrstra]

Thanks for checking. I'll merge soon.