-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff #315
Merged
Merged
Ruff #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
I've added fixes for NPY already, quite simple. I've removed FURB because it is apparently in preview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is again a big change, cleaning up many small things with Ruff automatically. This removes a lot of cruft. In short, I'm using Ruff for this instead of many other linters because it is fast and it has the most comprehensive rule set implemented, many of which have automatic fixes. The complete list can be found here: https://docs.astral.sh/ruff/rules/
Only the first commit (Basic Ruff configuration) required some decisions that are worth reviewing. All remaining commits are rather mindless.
I'm planning to YOLO-merge this Wednesday, May 29, unless reviewed and approved earlier.
For the bigger picture, see #313