Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff #315

Merged
merged 18 commits into from
May 29, 2024
Merged

Ruff #315

merged 18 commits into from
May 29, 2024

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented May 22, 2024

This is again a big change, cleaning up many small things with Ruff automatically. This removes a lot of cruft. In short, I'm using Ruff for this instead of many other linters because it is fast and it has the most comprehensive rule set implemented, many of which have automatic fixes. The complete list can be found here: https://docs.astral.sh/ruff/rules/

Only the first commit (Basic Ruff configuration) required some decisions that are worth reviewing. All remaining commits are rather mindless.

I'm planning to YOLO-merge this Wednesday, May 29, unless reviewed and approved earlier.

For the bigger picture, see #313

@tovrstra tovrstra marked this pull request as draft May 22, 2024 08:47
@tovrstra tovrstra marked this pull request as ready for review May 22, 2024 10:03
@tovrstra
Copy link
Member Author

I've added fixes for NPY already, quite simple. I've removed FURB because it is apparently in preview.

@tovrstra tovrstra merged commit 486e413 into theochem:main May 29, 2024
7 checks passed
@tovrstra tovrstra deleted the ruff branch May 29, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant