Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the shell prompt in "Copy" links for guides #883

Closed
cowboyd opened this issue Mar 4, 2021 · 1 comment · Fixed by #888
Closed

Don't include the shell prompt in "Copy" links for guides #883

cowboyd opened this issue Mar 4, 2021 · 1 comment · Fixed by #888
Assignees
Labels
@bigtest/cli Issues related to the `bigtest` command documentation

Comments

@cowboyd
Copy link
Member

cowboyd commented Mar 4, 2021

When following the installation process in our guides in #882 @zburke noted that the "copy" links to copy commands included the shell prompt, which is not super useful since you end up with a double shell prompt when you try to use it.

In other words, in the display $ npm install bigtest --save-dev, the string that should be copied is just the command itself:

npm install bigtest --save-dev

not the command plus shell prompt.

$ npm install bigtest --save-dev
@cowboyd cowboyd added documentation @bigtest/cli Issues related to the `bigtest` command labels Mar 4, 2021
@jnicklas
Copy link
Collaborator

jnicklas commented Mar 4, 2021

Can we just get rid of the leading $? Including it in the shell prompt is just a convention anyway. It use to be to distinguish from running as root using su where it would show a leading #, but no one ever does this these days anyway. My prompt does not include the $ at all for example:

Screenshot 2021-03-04 at 09 50 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@bigtest/cli Issues related to the `bigtest` command documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants