-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "restart" for RemoteDB services #925
Conversation
before:
after
|
@@ -38,6 +38,10 @@ def stop | |||
[0, db_status.last] | |||
end | |||
|
|||
def restart | |||
db_status("It can't be restarted") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ambiguous, and I am trying to think through better wording:
- Must be restarted manually
- Cannot be restarted by #{tool-name}
- Remote databases are not managed by #{tool-name}, they must be restarted by you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. But it's in line with enable
/disable
in this file, and @lpramuk pointed out that having some kind of MSG for start
/stop
would also be cool.
Further improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more explicit is my ask, how about:
Remote databases are not managed by #{tool-name} and therefore was not restarted.
700407c
to
44e7679
Compare
It's not really a restart, as we can't control it, but it checks the DB and returns the status properly. Fixes: 7cdffe7
44e7679
to
14f071d
Compare
It's not really a restart, as we can't control it, but it checks the DB
and returns the status properly.
Fixes: 7cdffe7