Formally turn snippet into module #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
9 tasks
aneta-petrova
removed
Needs tech review
maximiliankolb
approved these changes
Feb 13, 2025
|
You are right, Max, let's try to do things properly. The module now has a level 1 heading and a leveloffset is applied for the include directives. Can you please re-review @maximiliankolb? |
maximiliankolb
approved these changes
Feb 13, 2025
aneta-petrova
added a commit
to aneta-petrova/foreman-documentation
that referenced
this pull request
Feb 13, 2025
(cherry picked from commit b46d0d3) Applies the change to one more guide (Administering with Ansible)
9 tasks
|
Merged to "master" but no cherry-picks because 3.13 has one more guide that is also affected by this. To be extra safe, I want to do a separate PR: #3669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Turning the 'guide not ready yet' snippet into a proper module with its own heading.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
This came up in #3653. Adding the ribbon/banner causes build failures if there are headings missing in certain places. The 'guide not ready yet' snippet is one of them.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Checklists
Please cherry-pick my commits into: