Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename guide #3656

Closed
wants to merge 1 commit into from
Closed

Rename guide #3656

wants to merge 1 commit into from

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

Use underscore for guide names.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

follow-up to #3528.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Feb 12, 2025
@github-actions GitHub Actions
Copy link

The PR preview for 1b1b81d is available at theforeman-foreman-documentation-preview-pr-3656.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@apinnick
Copy link
Contributor

I'm not sure why hyphenated terms require the hyphen to be replaced with an underscore.

@maximiliankolb maximiliankolb deleted the rename_guide branch February 12, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apinnick apinnick Awaiting requested review from apinnick

Assignees
No one assigned
Labels
Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximiliankolb @apinnick