Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show managing hosts for all flavours #3594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show managing hosts for all flavours #3594

wants to merge 1 commit into from

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Jan 17, 2025 •
edited
Loading

What changes are you introducing?

Show "Managing Hosts" for all flavours

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Part of #396

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Needs tech ACK for:

  • Is "tracer" a Katello-only feature? -> Yes ✔️
  • Does Leapp on EL hosts work without Katello? -> Yes, no change necessary.
  • Is "Deploying a SSL certificate to hosts" Katello-only? -> still ❓

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

no cherry-picks

@maximiliankolb maximiliankolb force-pushed the show_managing_hosts_for_all_flavours branch from 9b36aa6 to e9b5b7e Compare January 17, 2025 15:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

The PR preview for c12c3a2 is available at theforeman-foreman-documentation-preview-pr-3594.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@Lennonka Lennonka requested a review from ekohl January 20, 2025 20:58
@Lennonka Lennonka added the Needs tech review Requires a review from the technical perspective label Feb 3, 2025
@jeremylenz
Copy link
Contributor

Does Leapp on EL hosts work without Katello?

I think it would. (The foreman-leapp plugin provides that.) But I can see leaving the katello since it has that note in there about the RHEL subscription.

@maximiliankolb maximiliankolb force-pushed the show_managing_hosts_for_all_flavours branch from e9b5b7e to c12c3a2 Compare February 5, 2025 07:14
maximiliankolb
maximiliankolb commented Feb 5, 2025
View reviewed changes
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied both suggestions. RE leapp: I did not find any mentions of content/subscriptions/katello in guides/common/modules/proc_upgrading-hosts-to-next-major-release.adoc.

Open remaining question is about SSL certs.

guides/common/assembly_administering-hosts.adoc Show resolved Hide resolved
guides/common/assembly_administering-hosts.adoc Show resolved Hide resolved
@maximiliankolb
Copy link
Contributor Author

Open question

Is everything after line 51 Katello-only? https://github.com/theforeman/foreman-documentation/blob/master/guides/common/assembly_registering-hosts.adoc?plain=1#L51

@jeremylenz
Copy link
Contributor

Puppet agent definitely isn't Katello.

@adamruzicka
Copy link
Contributor

Ansible roles (L56) are not katello-only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylenz jeremylenz jeremylenz left review comments

@ekohl ekohl Awaiting requested review from ekohl

Assignees
No one assigned
Labels
Needs tech review Requires a review from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximiliankolb @jeremylenz @adamruzicka @Lennonka