add return statements to functionsList.php

thecodingmachine · Feb 9, 2025 · 47a1689 · 47a1689
1 parent bd3f11f
commit 47a1689
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/generated/functionsList.php b/generated/functionsList.php
diff --git a/generator/src/Commands/GenerateCommand.php b/generator/src/Commands/GenerateCommand.php
@@ -97,7 +97,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $fileCreator->generateVersionSplitters($moduleName, FileCreator::getSafeRootDir() . "/generated/", \array_keys($versions));
             $fileCreator->createExceptionFile((string) $moduleName);
         }
-        $fileCreator->generateVersionSplitters("functionsList", FileCreator::getSafeRootDir() . "/generated/", \array_keys($versions));
+        $fileCreator->generateVersionSplitters("functionsList", FileCreator::getSafeRootDir() . "/generated/", \array_keys($versions), true);
 
         $this->runCsFix($output);
 

diff --git a/generator/src/Generator/FileCreator.php b/generator/src/Generator/FileCreator.php
@@ -68,18 +68,19 @@ public function generatePhpFile(array $functions, array $missingFunctions, strin
     /**
      * @param string[] $versions
      */
-    public function generateVersionSplitters(string $module, string $path, array $versions): void
+    public function generateVersionSplitters(string $module, string $path, array $versions, bool $return = false): void
     {
         $lcModule = \lcfirst($module);
         $stream = \fopen($path.$lcModule.'.php', 'w');
         if ($stream === false) {
             throw new \RuntimeException('Unable to write to '.$path);
         }
+        $return = $return ? "return " : "";
         \fwrite($stream, "<?php\n");
         foreach ($versions as $version) {
             if (file_exists("$path/$version/$lcModule.php")) {
                 \fwrite($stream, "\nif (str_starts_with(PHP_VERSION, \"$version.\")) {");
-                \fwrite($stream, "\n    require_once __DIR__ . '/$version/$lcModule.php';");
+                \fwrite($stream, "\n    {$return}require_once __DIR__ . '/$version/$lcModule.php';");
                 \fwrite($stream, "\n}");
             }
         }