Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBR-115. Create 2 options for installing the library #56

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

romina1601
Copy link
Member

@romina1601 romina1601 commented Nov 4, 2024

We need to separate frontend dependencies from backend dependencies
More details on this issue: EBR-115

…nt-end dependencies from backend dependencies
@liadomide liadomide added the documentation Improvements or additions to documentation label Nov 4, 2024
Copy link
Member

@liadomide liadomide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test this., but by reading the code change it looks fine to me.

Copy link
Member

@liadomide liadomide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we should also change the build actions s to install full, not light

Copy link

sonarqubecloud bot commented Nov 4, 2024

@915-Misan-Teodora 915-Misan-Teodora merged commit 77feaa3 into mergeFromXircuitsRepo Nov 5, 2024
8 checks passed
@liadomide liadomide deleted the EBR-115 branch November 5, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants