Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pin matrix jk60rgb.json #2415

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fix pin matrix jk60rgb.json #2415

merged 1 commit into from
Feb 10, 2025

Conversation

alabahuy
Copy link
Contributor

@alabahuy alabahuy commented Feb 9, 2025

Description

update pin matrix jk60rgb

QMK Pull Request

qmk/qmk_firmware#24485

VIA Keymap Pull Request

the-via/qmk_userspace_via#17

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot Cipulot merged commit e903a0b into the-via:master Feb 10, 2025
2 checks passed
@alabahuy alabahuy deleted the jk60rgb branch February 10, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants