Adding 1u center column layout to Promenade (HS) #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Feags I suggest pulling the latest changes of the repo and properly formatting only the file you are targeting. this PR seems to change the formatting of 2 other JSON unrelated to the PR. |
Adding updated boredwalk for personal. Updating promenade
Removing Boredwalk and other personal builds for Promenade HS update PR
- got the _VIA_ JSON definition file from the Discord server of the maker - removed the keys, which are not present on the PCB - added colors as per specification
Co-authored-by: Cipulot <40441626+Cipulot@users.noreply.github.com>
Feags
force-pushed
the
kradoindustries-dev-branch
branch
from
529013c to
950d077
Compare
Adding 1u center column after rebasing branch.
…/via-keyboards into kradoindustries-dev-branch
Merged from master and removed the other 2 files. Should just be the one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Promenade comes in two layouts: 1.5u center column and 1u center column. It is 1.5u by default. The 1u and 1.5u pcbs are exactly the same, only differentiated by which key locations have hotswap sockets. The original firmware for the Promenade only had the 1.5u center layout. This change adds 1u layout option.
QMK Pull Request
Original Promenade Firmware added
Promenade Layout updated
VIA Keymap Pull Request
the-via/qmk_userspace_via#52
Checklist
0xFEED