Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PW88 addition #2142

Merged
merged 3 commits into from
Mar 11, 2024
Merged

PW88 addition #2142

merged 3 commits into from
Mar 11, 2024

Conversation

SmollChungus
Copy link
Contributor

Description

Addition of VIA definition for the PW88 PCB

QMK Pull Request

qmk/qmk_firmware#21482

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move file to v3/pw88/pw88.json to reflect QMK tree

v3/smoll/pw88.json Outdated Show resolved Hide resolved
Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
@SmollChungus
Copy link
Contributor Author

Please move file to v3/pw88/pw88.json to reflect QMK tree

My apologies. On the QMK tree, the PW88 firmware is being moved to the 'smoll' folder as per qmk/qmk_firmware#22401. However the 'smoll' folder currently only exists on QMK's dev branch and hasn't been pulled into master yet.

Should I update this PR to reflect the current tree and make a new commit once the 'smoll' folder hits master, or temporarily close this PR? Thanks in advance!

@Xelus22
Copy link
Collaborator

Xelus22 commented Feb 3, 2024

Please move file to v3/pw88/pw88.json to reflect QMK tree

My apologies. On the QMK tree, the PW88 firmware is being moved to the 'smoll' folder as per qmk/qmk_firmware#22401. However the 'smoll' folder currently only exists on QMK's dev branch and hasn't been pulled into master yet.

Should I update this PR to reflect the current tree and make a new commit once the 'smoll' folder hits master, or temporarily close this PR? Thanks in advance!

Could probably just wait until the breaking changes from develop go in

@Xelus22 Xelus22 added the develop merged Waiting for merge into QMK master label Feb 11, 2024
@dunk2k dunk2k mentioned this pull request Feb 14, 2024
7 tasks
v3/smoll/pw88.json Outdated Show resolved Hide resolved
Applied correct key colors scheme as per documentation.
@Cipulot
Copy link
Collaborator

Cipulot commented Mar 11, 2024

image

QMK Breaking Changes Q1 '24 passed and the folder structure now matches.

I've also aligned the KLE keys' color to the required one from the documentation while maintaining the accent keys proposed in the original PR.

Ping to @SmollChungus for notification.
Cheers 🍺

@Cipulot Cipulot merged commit 51ebb82 into the-via:master Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop merged Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants