-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PW88 addition #2142
PW88 addition #2142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move file to v3/pw88/pw88.json
to reflect QMK tree
Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
My apologies. On the QMK tree, the PW88 firmware is being moved to the 'smoll' folder as per qmk/qmk_firmware#22401. However the 'smoll' folder currently only exists on QMK's dev branch and hasn't been pulled into master yet. Should I update this PR to reflect the current tree and make a new commit once the 'smoll' folder hits master, or temporarily close this PR? Thanks in advance! |
Could probably just wait until the breaking changes from develop go in |
Applied correct key colors scheme as per documentation.
QMK Breaking Changes Q1 '24 passed and the folder structure now matches. I've also aligned the KLE keys' color to the required one from the documentation while maintaining the accent keys proposed in the original PR. Ping to @SmollChungus for notification. |
Description
Addition of VIA definition for the PW88 PCB
QMK Pull Request
qmk/qmk_firmware#21482
Checklist
0xFEED