Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all as read doesn't respect search/filtering #1892

Open
biolauri opened this issue Jan 15, 2025 · 2 comments
Open

Mark all as read doesn't respect search/filtering #1892

biolauri opened this issue Jan 15, 2025 · 2 comments

Comments

@biolauri
Copy link

Describe the bug
The Mark all as read button in the More/Actions dropdown does mark messages as read which are not displayed in the list due to an active search.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Inbox
  2. Enter any search term
  3. Click on the overflow/hamburger menu
  4. Click on Mark all as read
  5. Remove search
  6. See that all mails are marked as read, not only the ones you searched for

Expected behavior
I would expect that the Mark all as read button does only mark mails which were searched for as read.

Please complete the following information:

  • Browser: Chrome 131
  • IMAP daemon: Dovecot
  • PHP version: 8.1/8.2/8.3
  • SnappyMail Version: 2.38.2
  • Mode: Probably standalone

Debug/logging information
Not possible as I'm not hosting the SnappyMail myself

Additional context
I'd say, it's very confusing that Mark all as read doesn't reflect the search status as I see the following use case:

  • User wants to mark all mails as read: Possible w/o any search term even if Mark all as read would only delete the ones searched for
  • User wants to mark only the mails being searched for as read: Currently not possible with more mails than pagination limit as I can't mark all mails altogether and would have to repeat this several times (once for every page)

Also, I see this as a bug as it's very unintuitive that all mails are marked as read and not only the ones listed below as all other actions in this overflow menu relate to the mails being listed/marked below, so it's not intuitive that Mark all as read is the only action that's ignoring the search.

@noticz
Copy link

noticz commented Jan 15, 2025

If there is a search criteria being used then you would need to click the select all checkbox at the top and then click Mark as read.

I think the mark all messages as read should stay how it is. It does what it says... Marks all messages as read.

@biolauri
Copy link
Author

biolauri commented Feb 12, 2025

If there is a search criteria being used then you would need to click the select all checkbox at the top and then click Mark as read.

But that's a hassle if you've got plenty of mails because with the Select all -checkbox, one can only select all of the current page.

I think the mark all messages as read should stay how it is. It does what it says... Marks all messages as read.

I'd disagree here. All items in the same overflow menu respect the current search criteria. So, with the context of the button, it does not what it says. Also, because the all is not specified here. It could be:

  1. All messages of the whole account
  2. All messages of the current folder (current behaviour)
  3. All messages in the current search (suggested behaviour due to context)
  4. All messages currently visible (can be achieved by the Select all-checkbox)

So, to state that the button does what it says, it has to be renamed to Mark all messages in current folder as read, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants