Add cron job functionality and error logging enhancements #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the 'node-cron' library has been added to package.json to provide cron job functionality. This supports scheduling periodic tasks such as daily task reports. Error logging has been enhanced within scripts/rebalance.ts, converting direct messaging to a cumulative log recording and event generation system. This results in clearer and more manageable error tracking and reporting. License data in the package-lock.json has also been modified.
The updated code introduces the use of 'node-cron' library for task scheduling. It also includes significant enhancements to the error logging mechanism in scripts/rebalance.ts, replacing direct messaging with a cumulated log and event recording system. This alteration provides more structured and accessible oversight of error events.
The default time for the cronDailyReport has been modified. Additionally, the error handling logic within scripts/rebalance.ts has been significantly refactored for simplification and improvement. The EthersError interface was removed and the functionality of logErrorEvent was merged into logEvent, making error handling more streamlined and less cluttered.
The default value for the isError parameter in the logEvent function within scripts/rebalance.ts has been changed from true to false. This might help suppressing unwanted error messages unless they are specifically invoked.
Added a new environmental variable, TETU_EXCLUDE_ERROR_LOGS, to adjuster rebalance script error logs. Also, modified the logEvent function to prevent default error messaging. This update provides more control on error log generation and helps to avoid unnecessary noise in logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the 'node-cron' library has been added to package.json to provide cron job functionality. This supports scheduling periodic tasks such as daily task reports. Error logging has been enhanced within scripts/rebalance.ts, converting direct messaging to a cumulative log recording and event generation system. This results in clearer and more manageable error tracking and reporting. License data in the package-lock.json has also been modified.