Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the delete process #80

Merged
merged 2 commits into from
May 22, 2023
Merged

Optimize the delete process #80

merged 2 commits into from
May 22, 2023

Conversation

rabauss
Copy link
Contributor

@rabauss rabauss commented Jan 19, 2023

While working for #79 I realized that we have some optimizations in our fork for the delete process.

  • trigger the ondelete_callback while deletion of language variants
  • do not call multilanguage deletition if child record is not a multilingual dataContainer

aschempp
aschempp reviewed Mar 16, 2023
View reviewed changes
@rabauss
Copy link
Contributor Author

rabauss commented Apr 28, 2023

@aschempp What about this PR?

@aschempp aschempp merged commit 15af64d into terminal42:main May 22, 2023
@aschempp
Copy link
Member

Thank you @rabauss

@rabauss rabauss deleted the feature/delete branch June 5, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabauss @aschempp