From e2811bc62bacdfb275dbc48b04b35b6ea76b5c10 Mon Sep 17 00:00:00 2001
From: Abigael Tiony <130055999+Abigael-JT@users.noreply.github.com>
Date: Tue, 4 Feb 2025 17:05:23 +0200
Subject: [PATCH] test resource closed after use in FilterTypesTest class,
 removed unnecessary semicolon

---
 .../teragrep/bloomfilter/FilterTypesTest.java | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterTypesTest.java b/src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterTypesTest.java
index ebdd840b..aee51df5 100644
--- a/src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterTypesTest.java
+++ b/src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterTypesTest.java
@@ -49,11 +49,13 @@
 import com.typesafe.config.ConfigFactory;
 import nl.jqno.equalsverifier.EqualsVerifier;
 import org.apache.spark.util.sketch.BloomFilter;
+import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.sql.Connection;
+import java.sql.DriverManager;
 import java.sql.ResultSet;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -65,15 +67,14 @@
 
 class FilterTypesTest {
 
-    Connection conn;
-    final String username = "sa";
-    final String password = "";
-    final String connectionUrl = "jdbc:h2:mem:test;MODE=MariaDB;DATABASE_TO_LOWER=TRUE;CASE_INSENSITIVE_IDENTIFIERS=TRUE";
+    private final String username = "sa";
+    private final String password = "";
+    private final String connectionUrl = "jdbc:h2:mem:test;MODE=MariaDB;DATABASE_TO_LOWER=TRUE;CASE_INSENSITIVE_IDENTIFIERS=TRUE";
+    private final Connection conn = Assertions
+            .assertDoesNotThrow(() -> DriverManager.getConnection(connectionUrl, username, password));
 
     @BeforeEach
     public void setup() {
-        Config config = ConfigFactory.parseProperties(defaultProperties());
-        this.conn = new LazyConnection(config).get();
         Assertions.assertDoesNotThrow(() -> {
             conn.prepareStatement("DROP ALL OBJECTS").execute(); // h2 clear database
         });
@@ -90,6 +91,11 @@ public void setup() {
 
     }
 
+    @AfterEach
+    public void teardown() {
+        Assertions.assertDoesNotThrow(conn::close);
+    }
+
     @Test
     public void testSortedMapMethod() {
         Config config = ConfigFactory.parseProperties(defaultProperties());
@@ -136,12 +142,12 @@ public void testWriteFilterTypesToDatabase() {
             Assertions.assertEquals(3, fppList.size());
             Assertions.assertEquals(Arrays.asList(1000L, 2000L, 3000L), expectedSizeList);
             Assertions.assertEquals(Arrays.asList(0.01, 0.02, 0.03), fppList);
+            Assertions.assertDoesNotThrow(result::close);
         });
     }
 
     @Test
     public void testEquals() {
-        ;
         Config config = ConfigFactory.parseProperties(defaultProperties());
         FilterTypes filterTypes1 = new FilterTypes(config);
         FilterTypes filterTypes2 = new FilterTypes(config);