Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue_486 #487

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

issue_486 #487

wants to merge 4 commits into from

Conversation

Abigael-JT
Copy link
Contributor

@Abigael-JT Abigael-JT commented Jan 24, 2025 •
edited
Loading

  • Removed null assignment and redundant casting
  • Replaced commented out code in if statement with an exception
  • Returned NullNode instead of null
  • Added an exception to avoid a Null pointer exception if aggregation column is null

@Abigael-JT Abigael-JT requested a review from elliVM January 24, 2025 12:24
@Abigael-JT Abigael-JT changed the title removed null assignment and redundant casting, returned NullNode inst… issue_486 Jan 24, 2025
elliVM
elliVM requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@elliVM elliVM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java Outdated Show resolved Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java Outdated Show resolved Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java Show resolved Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java Show resolved Hide resolved
@Abigael-JT
Copy link
Contributor Author

changes made

@Abigael-JT Abigael-JT marked this pull request as ready for review January 28, 2025 10:59
@Abigael-JT Abigael-JT linked an issue Jan 28, 2025 that may be closed by this pull request
Method called on a null object in EventstatsTransformation class #486
Open
@Abigael-JT Abigael-JT requested a review from 51-code January 28, 2025 11:03
51-code
51-code requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about the exceptions.

src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java Outdated Show resolved Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java Outdated Show resolved Hide resolved
@Abigael-JT
Copy link
Contributor Author

Removed unnecessary check and clarified exception message if the given command is not an aggregation function

@Abigael-JT Abigael-JT requested a review from 51-code January 29, 2025 10:29
@Abigael-JT Abigael-JT requested a review from 51-code January 29, 2025 11:04
51-code
51-code approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Abigael-JT Abigael-JT requested a review from kortemik January 29, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliVM elliVM elliVM approved these changes

@51-code 51-code 51-code approved these changes

@kortemik kortemik Awaiting requested review from kortemik

Assignees

@elliVM elliVM

@Abigael-JT Abigael-JT

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method called on a null object in EventstatsTransformation class
3 participants
@Abigael-JT @elliVM @51-code