Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17536: add matmul output mem config validation #18721

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bbradelTT
Copy link
Contributor

@bbradelTT bbradelTT commented Mar 6, 2025

Ticket

Link to Github Issue #17536

Problem description

  • upstream users need to know whether output memory configs are valid or not

What's changed

  • add checks for output memory config
  • add a note about it
  • fix tests/models to pass in output memory config with no shard spec instead of shard spec of input tensor to avoid incorrect comparison

Checklist

@bbradelTT bbradelTT force-pushed the bbradel_17536_check_config branch from 3523ad7 to b8b19aa Compare March 6, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants