-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#15061: Expose replicate and 1D shard mappers #18720
Draft
jjiangTT
wants to merge
75
commits into
main
Choose a base branch
from
jjiang/15061-pybind_sharding_mappers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests, simplify parallel signatures
d6f1d3c
to
9a6c50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
The current pybinds leverage pytorch for sharding, replication, and concatenation rather than doing it natively. This is being fixed slowly with a series of PRs that will deprecate the existing ones in distributed.py with c++ pybinds backed by xtensor.
What's changed
Expose C++ pybinds from existing classes in distribute_tensor.cpp/hpp
Extend distributed/api.cpp's aggregate_tensor to accept borrowedstorage types and aggregate them into a multihoststorage tensor as well
Add temporary forks in ttnn/operations/core.py to redirect cpp classes to the new path as the old one is replaced
Change all existing usages of replicate and shard to
Checklist