Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Cleanup/optimize some dynamic noc code #18704

Merged
merged 1 commit into from
Mar 6, 2025
Merged

#0: Cleanup/optimize some dynamic noc code #18704

merged 1 commit into from
Mar 6, 2025

Conversation

tt-aho
Copy link
Contributor

@tt-aho tt-aho commented Mar 6, 2025

Ticket

Link to Github Issue

Problem description

Suggestions from @pgkeller on some code cleanup/reorg and some performance changes.
Specifically, tagging the L1 reads/writes with tt_l1_ptr instead of using NOC_READ/WRITE_REG, and moving the register reads up front during init to pipeline and hide latency.

What's changed

Removed array and switched to compile time raw address calculation to make the address derivation clearer.
Tagged L1 reads/writes as tt_l1_ptr.
Moved register reads up front.

Checklist

Copy link
Contributor

@pgkeller pgkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment and then all good

@tt-aho tt-aho force-pushed the aho/noc-cleanup branch from cd38e01 to d601481 Compare March 6, 2025 15:13
@tt-aho tt-aho force-pushed the aho/noc-cleanup branch from d601481 to eae588d Compare March 6, 2025 15:30
@tt-aho tt-aho merged commit 5b95f51 into main Mar 6, 2025
210 of 212 checks passed
@tt-aho tt-aho deleted the aho/noc-cleanup branch March 6, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants