#0: Cleanup/optimize some dynamic noc code #18704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Suggestions from @pgkeller on some code cleanup/reorg and some performance changes.
Specifically, tagging the L1 reads/writes with tt_l1_ptr instead of using NOC_READ/WRITE_REG, and moving the register reads up front during init to pipeline and hide latency.
What's changed
Removed array and switched to compile time raw address calculation to make the address derivation clearer.
Tagged L1 reads/writes as tt_l1_ptr.
Moved register reads up front.
Checklist