Add downsample unit tests #18644
Merged
Add downsample unit tests #18644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrsticTT
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na,
bbradelTT and
omilyutin-tt
as code owners
| from loguru import logger | ||
|
|
||
| import ttnn | ||
| from tt_lib.utils import _nearest_y |
There was a problem hiding this comment.
remove references to tt_lib
| @pytest.mark.parametrize( | ||
| "batch_size, output_channels, input_channels, input_height, input_width, stride_h, stride_w, num_cores, grid_size, height_sharded", | ||
| ( | ||
| # (10, 64, 64, 16, 16, 2, 2, 20, (10,2), False), |
There was a problem hiding this comment.
can we uncomment these
| # Convert NCHW to NHWC shape | ||
| A_pyt_nhwc = torch.permute(A_pyt, (0, 2, 3, 1)) | ||
| A_pyt_nhwc = A_pyt_nhwc.reshape(1, 1, batch_size * input_height * input_width, input_channels) | ||
| # for i in range(2): |
There was a problem hiding this comment.
remove code under comments
pavlejosipovic
approved these changes
Mar 5, 2025
bbradelTT
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Issue: #18201
What's changed
Downsample tests belonged to tt eager tests, which are deleted. Reverted same test coverage and put it in unit tests.
Checklist