#13385: ttnn.round direct kernel implementation #17673
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcw-anasuya
force-pushed
the
anasuya/round_op
branch
9 times, most recently
from
39efb99 to
8f140f3
Compare
mcw-anasuya
force-pushed
the
anasuya/round_op
branch
3 times, most recently
from
3888957 to
18f18b4
Compare
umadevimcw
requested changes
Mar 5, 2025
tt_metal/hw/ckernels/blackhole/metal/llk_api/llk_sfpu/ckernel_sfpu_round.h
Show resolved
Hide resolved
mcw-anasuya
requested review from
umadevimcw,
VirdhatchaniKN,
Aswinmcw,
KalaivaniMCW and
mouliraj-mcw
mcw-anasuya
force-pushed
the
anasuya/round_op
branch
from
18f18b4 to
9039d15
Compare
umadevimcw
approved these changes
Mar 5, 2025
mcw-anasuya
requested review from
patrickroberts,
sjameelTT,
ntarafdar,
dchenTT,
rtawfik01,
rdjogoTT and
ttmtrajkovic
as code owners
VirdhatchaniKN
approved these changes
Mar 6, 2025
mcw-anasuya
force-pushed
the
anasuya/round_op
branch
from
9039d15 to
5f7f1e3
Compare
Comment on lines
44
to
52
| const float TABLE[] = { | ||
| 1e-45F, 1e-44F, 1e-43F, 1e-42F, 1e-41F, 1e-40F, 1e-39F, 1e-38F, 1e-37F, 1e-36F, 1e-35F, 1e-34F, | ||
| 1e-33F, 1e-32F, 1e-31F, 1e-30F, 1e-29F, 1e-28F, 1e-27F, 1e-26F, 1e-25F, 1e-24F, 1e-23F, 1e-22F, | ||
| 1e-21F, 1e-20F, 1e-19F, 1e-18F, 1e-17F, 1e-16F, 1e-15F, 1e-14F, 1e-13F, 1e-12F, 1e-11F, 1e-10F, | ||
| 1e-9F, 1e-8F, 1e-7F, 1e-6F, 1e-5F, 1e-4F, 1e-3F, 1e-2F, 1e-1F, 1e0F, 1e1F, 1e2F, | ||
| 1e3F, 1e4F, 1e5F, 1e6F, 1e7F, 1e8F, 1e9F, 1e10F, 1e11F, 1e12F, 1e13F, 1e14F, | ||
| 1e15F, 1e16F, 1e17F, 1e18F, 1e19F, 1e20F, 1e21F, 1e22F, 1e23F, 1e24F, 1e25F, 1e26F, | ||
| 1e27F, 1e28F, 1e29F, 1e30F, 1e31F, 1e32F, 1e33F, 1e34F, 1e35F, 1e36F, 1e37F, 1e38F, | ||
| }; |
There was a problem hiding this comment.
Would suggest moving this table out of calculate_round<APPROXIMATE, ITERATIONS> and declaring it as inline constexpr instead of const to ensure that this table is statically initialized instead of stack initialized, and also so that it isn't materialized separately for each instantiation of calculate_round.
There was a problem hiding this comment.
@patrickroberts Moved the table outside the loop as you suggested.
mcw-anasuya
force-pushed
the
anasuya/round_op
branch
from
5f7f1e3 to
d92f1cb
Compare
mcw-anasuya
force-pushed
the
anasuya/round_op
branch
from
d92f1cb to
46408eb
Compare
rdjogoTT
reviewed
Mar 7, 2025
| ALWI void round_tile_init() { MATH((llk_math_eltwise_unary_sfpu_round_init<APPROX>())); } | ||
|
|
||
| /** | ||
| * Performs round operation on each row of a tile. |
There was a problem hiding this comment.
we can make the formatting of the comment nice by using clang on/off now, see other files in this DIR for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#13385
Problem description
ttnn.round is currently implemented as a combination of ttnn.floor, ttnn.add, etc. This op can be implemented as a kernel op. #13851 has laid the groundwork for this issue to which I have added a few modifications.
What's changed
Checklist