Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix (tfjs-react-native): fallback to localUri when uri in unavailable in bundleResourceIO! #8504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devrayat000
Copy link

This bug was mentioned in #8501
This only occurs in development release builds and where expo-updates is installed. I fixed the bug in my own app by falling back to asset.localUri whenever asset.uri is not available.

Hope this helps!

Copy link

google-cla bot commented Jan 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@devrayat000 devrayat000 changed the title Bug fix (tfjs-react-native): fallback to localUri when uri in unavailable in bundleResourceIO Bug fix (tfjs-react-native): fallback to localUri when uri in unavailable in bundleResourceIO! Jan 22, 2025
@devrayat000 devrayat000 reopened this Jan 22, 2025
@devrayat000 devrayat000 reopened this Jan 22, 2025
@devrayat000 devrayat000 reopened this Jan 22, 2025
@devrayat000
Copy link
Author

Hi, I've fixed the bug mentioned in #8501. Could a collaborator please trigger the tests by running /gcbrun? Thank you!
@gaikwadrahul8 @mattsoulanille

@devrayat000
Copy link
Author

@Linchenn, kindly review my pull request.

@devrayat000 devrayat000 reopened this Jan 24, 2025
@devrayat000 devrayat000 marked this pull request as draft January 24, 2025 19:16
@devrayat000 devrayat000 marked this pull request as ready for review January 24, 2025 19:17
@devrayat000
Copy link
Author

@pyu10055 Could you please trigger the tests by running /gcbrun? Thank you!

@mattsoulanille
Copy link
Member

Sorry! Our presubmits are currently broken due to an issue with CI. I'll be taking a look as soon as I can, and I'll let you know when it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants