Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated connector config debug statement to f-string #9

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

SteveMcGrath
Copy link
Contributor

@SteveMcGrath SteveMcGrath commented Jan 24, 2025

Description

Newly added debug statements to output the current environmental state had one of them incurrectly typed as a static
string instead of an f-string. This PR corrects that mistake.

Further string formatting was made consistent with ruff. This results in a larger than usual second commit, however resolves some inconsistency between earlier code and more recent code.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually confirmed with the template example and augmented the testing suite to check.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner January 24, 2025 15:18
@SteveMcGrath SteveMcGrath force-pushed the fix/f-string branch 5 times, most recently from 390115f to 4c76cb9 Compare January 24, 2025 22:00
@SteveMcGrath SteveMcGrath changed the title Updated connector configu debug statement to f-string Updated connector config debug statement to f-string Jan 24, 2025
@SteveMcGrath SteveMcGrath merged commit 2b491df into main Jan 24, 2025
3 checks passed
@SteveMcGrath SteveMcGrath deleted the fix/f-string branch January 24, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants