-
Notifications
You must be signed in to change notification settings - Fork 82
feat: add schema generation scripts and update dependencies #2662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rossnelson
wants to merge
6
commits into
main
Choose a base branch
from
dt-2864-add-generation-script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
35034d0
to
c2e115c
Compare
c2e115c
to
449a4b9
Compare
cd5a78e
to
24cf853
Compare
- Added new scripts for schema and type generation using Bun. - Updated dependencies in `package.json` and `pnpm-lock.yaml`. - Introduced `.tool-versions` for managing Node.js and Bun versions. - Updated `.gitignore` to include `/tmp`. - Modified several Svelte components for schema integration. - Added new schema-related files in `src/lib/schemas`. BREAKING CHANGE: Updated dependencies and introduced new scripts that require Bun. Ensure Bun is installed and configured before running the project. TIP: use [`asdf`](https://asdf-vm.com/) to manage multiple runtime versions
- Introduced `handleBunError` utility for standardized error handling. - Updated schema generation scripts to use `handleBunError`. - Enhanced error messages with actionable advice and resolution steps. - Improved schema generation logic for better reliability. - Updated dependencies in `package.json` and `pnpm-lock.yaml`.
24cf853
to
f854696
Compare
rossedfort
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me although I don't have a ton of context on this project.
* feat(schemas): add generated schemas * refactor(search-attributes): poc generated schema usage (#2645) Also: Refactored the `fetchSearchAttributesForNamespace` function to enhance readability and maintainability. Introduced helper functions for parsing responses, mutating attributes, and handling errors. Changes include: - Replaced inline logic with `parsedResponse` and `mutateSearchAttributes`. - Added `mapEntries` utility for transforming object entries. - Updated types to align with the new schema-based approach. - Removed redundant `ListSearchAttributesResponse` type. This improves code clarity and aligns with schema validation practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR introduces several updates and improvements to the project:
New Features:
.tool-versions
for managing Node.js and Bun versions.Dependency Updates:
package.json
andpnpm-lock.yaml
.zod
,json-schema-to-zod
, andopenapi-typescript
.Tooling Enhancements:
.gitignore
to include/tmp
.package.json
for better integration with Bun and schema generation.Codebase Changes:
src/lib/schemas
.Breaking Changes⚠️
Design Considerations 🎨
zod
andjson-schema-to-zod
for schema validation and type generation ensures better type safety and developer experience.Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
pnpm generate:schemas
.Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?