Async SetRampingVersion and SetCurrentVersion #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
reviewed
Apr 24, 2025
| @@ -201,6 +201,10 @@ message WorkerDeploymentInfo { | |||
|
|
|||
| RoutingConfig routing_config = 4; | |||
|
|
|||
| // Indicates whether the routing_config has been fully propagated to all | |||
| // relevant task queues and partitions. | |||
| enums.v1.TaskQueuePropagation routing_config_propagation_state = 6; | |||
There was a problem hiding this comment.
I wonder if even saying "task queue" and "propagation" is too much detail / too specific? Maybe something like "update state": "pending" or "completed"
Shivs11
reviewed
Apr 28, 2025
| @@ -201,6 +201,10 @@ message WorkerDeploymentInfo { | |||
|
|
|||
| RoutingConfig routing_config = 4; | |||
|
|
|||
| // Indicates whether the routing_config has been fully propagated to all | |||
| // relevant task queues and partitions. | |||
| enums.v1.TaskQueuePropagation routing_config_propagation_state = 6; | |||
There was a problem hiding this comment.
routing_config_propagation_state is something that's related to the routing information of a worker deployment info and I wonder if it's better suited to be present inside routing_config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
Synchronous task queue propagation meant that the lock on the Worker Deployment Manager was held for many seconds, meaning the APIs would be unavailable if there were large numbers of partitions. This allows us to have high availability APIs while being transparent about where tasks are being routed.
Breaking changes
Server PR