Skip to content

Commit

Permalink
Use PhoneLib 8.13.48 and prepare release
Browse files Browse the repository at this point in the history
- Fixing 17(0-5&7-9) length validation: Adapting Tests
- Change in Problems identifying mobile length 17x+Infix for VoiceMail: Adapting Tests
  • Loading branch information
Anrufliste committed Oct 23, 2024
1 parent 8dd90e2 commit 500317c
Show file tree
Hide file tree
Showing 3 changed files with 192 additions and 179 deletions.
5 changes: 4 additions & 1 deletion REPORTED_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,7 @@ Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8

Previous to Version 8.13.43 any German number within the range 17x was identified valid for both length 10 & 11. Now the 11 length case (176) is differentiated, that 176 is not validated valid with 10 digits. But 170-175, 177-179 is still validated valid for both length, but should be only valid with length of 10.

Google stated it is aware and will bring changes after investigation that users are not unblock.
Google stated it is aware and will bring changes after investigation that users are not unblock.

Google [fixed](https://github.com/google/libphonenumber/pull/3671/files#diff-5061a7d3c54ba589aacce00dcee1ce92e098c40034749bcae4c8a4780bb40233) it with [8.13.48](https://github.com/google/libphonenumber/pull/3671) on 16.10.2024
While normal mobile numbers are now aligend, voicemail numbers length is still problematic (BUG needs to be reported!).
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<artifactId>normalizer</artifactId>
<name>Phonenumber Normalizer</name>
<description>Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics.</description>
<version>1.3.1-SNAPSHOT</version>
<version>1.3.1</version>
<packaging>jar</packaging>
<url>https://github.com/telekom/phonenumber-normalizer</url>

Expand Down Expand Up @@ -86,7 +86,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>libphonenumber</artifactId>
<version>8.13.47</version>
<version>8.13.48</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -150,7 +150,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>geocoder</artifactId>
<version>2.241</version>
<version>2.242</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
Loading

0 comments on commit 500317c

Please sign in to comment.