tekton/images: remove skopeo… #2065
Conversation
tekton-robot
added
the
size/M
|
@afrittoli I think the image-build failure is "kind-of" expected 😅 |
|
Related to #1839. @afrittoli I think with the way the ci is currently setup, we can't get the |
|
/test check-pr-has-kind-label |
|
@vdemeester: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
needs-rebase
|
/test plumbing-image-build |
|
@afrittoli: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test plumbing-image-build |
|
@afrittoli: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test plumbing-image-build |
|
@afrittoli: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I don't think it is used anywhere, so let's not have to maintain it. And even if it is, we should use the skopeo image maintained by the skopeo project. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
afrittoli
force-pushed
the
remove-skopeo-image
branch
from
d250a2b to
f09d761
Compare
tekton-robot
removed
the
needs-rebase
|
/test plumbing-image-build |
|
@afrittoli: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When a dockerfile is removed, the build CI job fails today as it see the file in the list of modified ones, but cannot locate it to run the test. This still logs the missing file condition, but do not fail, so that we may pass CI on PRs that delete a dockerfile, like: - tektoncd#2065 - tektoncd#2064 Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
When a dockerfile is removed, the build CI job fails today as it see the file in the list of modified ones, but cannot locate it to run the test. This still logs the missing file condition, but do not fail, so that we may pass CI on PRs that delete a dockerfile, like: - #2065 - #2064 Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Changes
I don't think it is used anywhere, so let's not have to maintain
it. And even if it is, we should use the skopeo image maintained by
the skopeo project.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.