Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes go.mod #1300

Closed
wants to merge 2 commits into from
Closed

Fixes go.mod #1300

wants to merge 2 commits into from

Conversation

PuneetPunamiya
Copy link
Member

@PuneetPunamiya PuneetPunamiya commented Feb 6, 2025 •
edited
Loading

Fixes go.mod

  • This patch fixes alibabacloud-go/cr-20160607 license using a fork + replace, to take over the LICENSE check
    by replacing github.com/alibabacloud-go/cr-20160607 => github.com/vdemeester/cr-20160607 v1.0.1
  • Removes golang lint check from presubmit.sh as lint check is done in
    the workflow

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from puneetpunamiya after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2025
@PuneetPunamiya
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2025
@PuneetPunamiya PuneetPunamiya force-pushed the fixes-go.mod branch 2 times, most recently from 0bd8760 to 51d65a2 Compare February 7, 2025 06:56
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2025
@PuneetPunamiya PuneetPunamiya force-pushed the fixes-go.mod branch 3 times, most recently from f93c926 to 94e78a7 Compare February 7, 2025 12:18
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 7, 2025
@PuneetPunamiya PuneetPunamiya force-pushed the fixes-go.mod branch 2 times, most recently from 5354261 to 251c9b1 Compare February 7, 2025 15:38
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2025
@PuneetPunamiya PuneetPunamiya force-pushed the fixes-go.mod branch 2 times, most recently from 592ccbb to 74fad04 Compare February 10, 2025 08:03
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2025
@dependabot @PuneetPunamiya
Bump the all group across 1 directory with 8 updates
3809439 
Bumps the all group with 3 updates in the / directory: [github.com/in-toto/attestation](https://github.com/in-toto/attestation), [github.com/sigstore/cosign/v2](https://github.com/sigstore/cosign) and [github.com/tektoncd/pipeline](https://github.com/tektoncd/pipeline).


Updates `github.com/in-toto/attestation` from 1.1.0 to 1.1.1
- [Release notes](https://github.com/in-toto/attestation/releases)
- [Commits](in-toto/attestation@v1.1.0...v1.1.1)

Updates `github.com/sigstore/cosign/v2` from 2.4.1 to 2.4.2
- [Release notes](https://github.com/sigstore/cosign/releases)
- [Changelog](https://github.com/sigstore/cosign/blob/main/CHANGELOG.md)
- [Commits](sigstore/cosign@v2.4.1...v2.4.2)

Updates `github.com/sigstore/rekor` from 1.3.8 to 1.3.9
- [Release notes](https://github.com/sigstore/rekor/releases)
- [Changelog](https://github.com/sigstore/rekor/blob/main/CHANGELOG.md)
- [Commits](sigstore/rekor@v1.3.8...v1.3.9)

Updates `github.com/spiffe/go-spiffe/v2` from 2.4.0 to 2.5.0
- [Release notes](https://github.com/spiffe/go-spiffe/releases)
- [Changelog](https://github.com/spiffe/go-spiffe/blob/main/CHANGELOG.md)
- [Commits](spiffe/go-spiffe@v2.4.0...v2.5.0)

Updates `github.com/tektoncd/pipeline` from 0.66.0 to 0.68.0
- [Release notes](https://github.com/tektoncd/pipeline/releases)
- [Changelog](https://github.com/tektoncd/pipeline/blob/main/releases.md)
- [Commits](tektoncd/pipeline@v0.66.0...v0.68.0)

Updates `golang.org/x/exp` from 0.0.0-20240909161429-701f63a606c0 to 0.0.0-20241108190413-2d47ceb2692f
- [Commits](https://github.com/golang/exp/commits)

Updates `google.golang.org/grpc` from 1.69.4 to 1.70.0
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.69.4...v1.70.0)

Updates `google.golang.org/protobuf` from 1.36.3 to 1.36.4

---
updated-dependencies:
- dependency-name: github.com/in-toto/attestation
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: github.com/sigstore/cosign/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: github.com/sigstore/rekor
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: github.com/spiffe/go-spiffe/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: github.com/tektoncd/pipeline
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: golang.org/x/exp
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 10, 2025
@PuneetPunamiya PuneetPunamiya force-pushed the fixes-go.mod branch 3 times, most recently from 8b13cdc to dfd8735 Compare February 10, 2025 13:16
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2025
@PuneetPunamiya
Fixes go.mod
0b12087 
- This patch fixes alibabacloud-go/cr-20160607 license using a fork + replace, to take over the LICENSE check
  by replacing github.com/alibabacloud-go/cr-20160607 => github.com/vdemeester/cr-20160607 v1.0.1

- Removes golang lint check from presubmit.sh as lint check is done in
  the workflow

Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
@PuneetPunamiya
Copy link
Member Author

Closing this pr as it is handled and fixed here #1301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

@lcarva lcarva Awaiting requested review from lcarva

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PuneetPunamiya @tekton-robot