2025-02-04-add_vl_pipe_section_pipe_dn

[sjib]

Should solve #53

[sjib]

psql:/src/datamodel/scripts/../changelogs/0001/05_add_vl_pipe_section_pipe_dn.sql:43: ERROR:  foreign key constraint "fkey_vl_pipe_section_pipe_dn" cannot be implemented
DETAIL:  Key columns "nominal_diameter" and "code" are of incompatible types: text and integer.

[sjib]

Nominal_diameter is defined as text
ALTER TABLE tdh_od.pipe_section ADD COLUMN nominal_diameter text;

So we need to modify that.

[sjib]

Change type of column -- see https://stackoverflow.com/questions/7162903/how-to-alter-a-columns-data-type-in-a-postgresql-table (version that allows to have already data in db)

[sjib]

2025-02-04 16:43:24.285 UTC [110] ERROR:  function char_length(integer) does not exist
2025-02-04 16:43:24.285 UTC [110] HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
2025-02-04 16:43:24.285 UTC [110] STATEMENT:  ALTER TABLE tdh_od.pipe_section ALTER COLUMN nominal_diameter TYPE integer USING (NULLIF(nominal_diameter, '')::integer);

[sjib]

@ponceta Any idea how to change column type from text to integer in a more "safe" way? Do we need to consider to keep existing data?

[sjib]

Maybe more idea to deal with that issue: https://stackoverflow.com/questions/10518258/typecast-string-to-integer

[ponceta]

Suggested change

	ALTER TABLE tdh_od.pipe_section ADD COLUMN nominal_diameter integer;
	ALTER TABLE tdh_od.pipe_section ADD COLUMN material integer;

[ponceta]

Suggested change

	CREATE TABLE tdh_vl.pipe_section_pipe_dn () INHERITS (tdh_vl.value_list_base);
	CREATE TABLE tdh_vl.pipe material () INHERITS (tdh_vl.value_list_base);

[ponceta]

Suggested change

	psql "service=${PGSERVICE}" -v ON_ERROR_STOP=1 -f ${DIR}/changelogs/0001/05_add_vl_pipe_section_pipe_dn.sql
	psql "service=${PGSERVICE}" -v ON_ERROR_STOP=1 -f ${DIR}/changelogs/0001/05_add_vl_pipe_material.sql

[ponceta]

👍 on removing nominal diameter from table pipe_section

Change requested : name the material table tdh_vl.material and the corresponding foreign key pipe_section.material

[ponceta]

We had a similar case fixed by @rbovard on qwat/qwat-data-model@a44e1a0