Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: different validation rules for the cover file #352

Merged
merged 4 commits into from
Nov 24, 2023
Merged

fix: different validation rules for the cover file #352

merged 4 commits into from
Nov 24, 2023

Conversation

Zir0h
Copy link
Contributor

@Zir0h Zir0h commented Oct 27, 2023

Fix for #306

@github-actions
Copy link

github-actions bot commented Oct 27, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-24 13:21 UTC

@melMass
Copy link
Member

melMass commented Oct 27, 2023

Awesome!
I'm going to hold after reviewing jag's PR on that one since it's part of something I want to refactor there too, basically adding extra fields (data) instead of extra cases. The fields could be allowed_types, error_label etc .. The idea being providing extra information to "primitive" cases

melMass
melMass approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@melMass melMass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect in the meantime (regarding my previous comment) 😚

@melMass melMass merged commit 887f2a4 into main Nov 24, 2023
@melMass melMass deleted the fix-synchronize-allowed-filetypes-for-covers branch November 24, 2023 13:20
@Zir0h Zir0h mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melMass melMass melMass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zir0h @melMass