Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Swapping an object with 8.3tez price causes an rpc error #369

Closed
Zir0h opened this issue Dec 27, 2023 · 1 comment
Closed

[bug] Swapping an object with 8.3tez price causes an rpc error #369

Zir0h opened this issue Dec 27, 2023 · 1 comment
Labels
🐛 bug Something isn't working 🧹 needs triage The issue/PR was not yet reviewed by a maintainer

Comments

@Zir0h
Copy link
Contributor

Zir0h commented Dec 27, 2023

Describe the bug

Stu saw that swapping an objkt for 8.3tez causes an error. When you compare a working swap and a broken one, you can see a rounding error:

"args": [				                        "args": [
{					                          {
"int": "8300000.000000001"	      |	                            "int": "8400000"
},					                          },

Reproduction

No response

Expected behavior

No response

Platform and versions

I use arch btw

Console output

No response

Additional context

No response
@Zir0h Zir0h added 🐛 bug Something isn't working 🧹 needs triage The issue/PR was not yet reviewed by a maintainer labels Dec 27, 2023
Zir0h added a commit that referenced this issue Dec 27, 2023
@Zir0h
remove everything after the comma, see #369
347999e
@Zir0h Zir0h mentioned this issue Dec 27, 2023
Merged
@Zir0h
Copy link
Contributor Author

Zir0h commented Jan 5, 2024

Fixed with #370

@Zir0h Zir0h closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🧹 needs triage The issue/PR was not yet reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zir0h