Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear filters button #859

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

michielderoos
Copy link
Contributor

@michielderoos michielderoos commented Oct 26, 2022

Describe the Pull Request

Simple PR to add a button to clear filters

Todo

@michielderoos
Copy link
Contributor Author

Add clear filters button

Copy link
Contributor

@tristanhcole tristanhcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could do some work to improve this design. Maybe float to the right and as a secondary button? Or underneath the filters text? Mockup could be useful to put together first.

Screen Shot 2022-10-29 at 8 17 54 pm

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #859 (6b364a0) into master (3216731) will increase coverage by 0.35%.
The diff coverage is 0.00%.

❗ Current head 6b364a0 differs from pull request most recent head 8eaf255. Consider uploading reports for the commit 8eaf255 to get more accurate results

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   47.43%   47.79%   +0.35%     
==========================================
  Files         380      374       -6     
  Lines       19590    19432     -158     
  Branches     1830     1793      -37     
==========================================
- Hits         9292     9287       -5     
+ Misses      10283    10130     -153     
  Partials       15       15              
Flag Coverage Δ
javascript 4.50% <0.00%> (+0.09%) ⬆️
python 73.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/client/components/filterModule/filter.jsx 0.00% <0.00%> (ø)
app/server/models/credit_transfer.py 92.79% <0.00%> (-0.91%) ⬇️
app/server/api/disbursement_api.py 82.85% <0.00%> (-0.71%) ⬇️
app/client/utils.js 58.76% <0.00%> (ø)
app/client/sagas/rootSaga.ts 0.00% <0.00%> (ø)
app/client/genericState/index.ts 0.00% <0.00%> (ø)
app/client/genericState/sagas.ts 0.00% <0.00%> (ø)
app/client/genericState/actions.ts 0.00% <0.00%> (ø)
app/client/reducers/rootReducer.ts 0.00% <0.00%> (ø)
app/client/genericState/reducers.ts 0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants