Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEBRTC-2465][feat] Implement DTMF keyboard on Demo App #165

Merged
merged 6 commits into from
Jan 30, 2025
Merged

[WEBRTC-2465][feat] Implement DTMF keyboard on Demo App #165

merged 6 commits into from
Jan 30, 2025

Conversation

ai-swe-agent
Copy link

@ai-swe-agent ai-swe-agent commented Jan 30, 2025 •
edited by gbattistel
Loading

Description

Implements a DTMF keyboard feature in the iOS Demo App as requested in WEBRTC-2465.

Changes

  • Added DTMFKeyboardViewModel for handling DTMF functionality
  • Created DTMFKeyboardView with a phone-like keypad layout
  • Added DTMF button after speaker control in CallView
  • Implemented bottom sheet presentation for the DTMF keyboard

Implementation Details

  • The DTMF button uses the circle.grid.3x3.fill SF Symbol icon
  • Keyboard buttons use the specified colors:
    • Background: #F5F3E4
    • Foreground: #1D1D1D
  • Bottom sheet presentation with fixed height of 400 points
  • Text input field only accepts input from keypad buttons
IMG_1627.MP4

Jira Ticket: WEBRTC-2465

@gbattistel gbattistel merged commit 69f49ed into main Jan 30, 2025
1 check passed
@gbattistel gbattistel deleted the feat/WEBRTC-2465-dtfm branch January 30, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oliver-Zimmerman Oliver-Zimmerman Oliver-Zimmerman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ai-swe-agent @Oliver-Zimmerman @gbattistel @openhands-agent