Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Splash Screen and App Icon Adjustments - WEBRTC-2425 #153

Merged
merged 5 commits into from
Jan 17, 2025
Merged

[iOS] Splash Screen and App Icon Adjustments - WEBRTC-2425 #153

merged 5 commits into from
Jan 17, 2025

Conversation

ai-swe-agent
Copy link

@ai-swe-agent ai-swe-agent commented Jan 17, 2025 •
edited
Loading

Description

This PR implements the splash screen and app icon adjustments for the iOS WebRTC SDK demo app.

Changes

  • Updated app icons (already completed)
  • Updated launch screen:
    • Changed background color to #00E3AA
    • Replaced logo with telnyx-icon
    • Removed old telnyx-white logo
    • Updated constraints for centered icon
  • Created new splash screen:
    • Implemented using SwiftUI
    • White background with centered telnyx-logo
    • 2-second display duration before transitioning to main screen
    • Smooth transition to main storyboard
  • Asset updates:
    • Using telnyx-icon for launch screen
    • Using telnyx-logo for splash screen
    • All required assets already included in branch

Related Issues

  • WEBRTC-2425
  • WEBRTC-2418 (Flutter counterpart)

Testing

  • Verify app icon displays correctly
  • Confirm launch screen shows correct background color (#00E3AA)
  • Confirm launch screen shows centered telnyx-icon
  • Validate splash screen displays for 2 seconds
  • Confirm splash screen shows centered telnyx-logo
  • Check smooth transition to main screen
  • Ensure all logo replacements are working

Notes

  • All required assets are included in this branch
  • Implementation follows existing project patterns
  • SwiftUI used for new splash screen as requested

gbattistel and others added 5 commits January 17, 2025 10:06
@gbattistel
feat: demo app icons updated
306c05c
@gbattistel
chore: new logo asset added
ae02458
@openhands-agent
Update launch screen and add SwiftUI splash screen
3ae5811 
- Update launch screen:
  * Change background color to #00E3AA
  * Replace logo-white with telnyx-icon
  * Update constraints for centered icon

- Add SwiftUI splash screen:
  * White background with centered telnyx-logo
  * 2-second display duration
  * Smooth transition to main screen
@gbattistel
fix: build error. Added SplashScreen to the project.
363e6ae
@gbattistel
chore: removed comment
e67427f
gbattistel
gbattistel approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@gbattistel gbattistel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it's working now.

@gbattistel gbattistel merged commit 4636655 into init/WEBRTC-2332-app Jan 17, 2025
1 check passed
@gbattistel gbattistel deleted the feat/WEBRTC-2425-splash branch January 17, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbattistel gbattistel gbattistel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ai-swe-agent @gbattistel @openhands-agent