Initial SonarQube improvements

Author: vbaderks

setup/shell-change-notify-custom-action/dll_main.cpp

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: BSD-3-Clause
 
 #include <Windows.h>
-#include <msiquery.h>
+#include <MsiQuery.h>
 #include <ShlObj.h>
 
 unsigned int __stdcall SHChangeNotifyCustomAction(const MSIHANDLE install)

sonar-project.properties

@@ -0,0 +1,15 @@
+# SPDX-FileCopyrightText: © 2025 Team CharLS
+# SPDX-License-Identifier: BSD-3-Clause
+
+sonar.projectKey = team-charls_netpbm-wic-codec
+sonar.organization = team-charls
+
+# This is the name and version displayed in the SonarCloud UI.
+sonar.projectVersion = 1.0
+
+# Define the source code to scan (only scan files that are part of the NetPbm-WIC codec)
+sonar.sources = src/
+sonar.tests = test/
+
+# Encoding of the source code files. Default is the default system encoding, which is not correct.
+sonar.sourceEncoding=UTF-8

src/dll_main.cpp

@@ -167,13 +167,13 @@ void register_property_store()
 // ReSharper disable CppInconsistentNaming
 // ReSharper disable CppParameterNamesMismatch
 
-BOOL __stdcall DllMain(const HMODULE module, const DWORD reason_for_call, void* /*reserved*/) noexcept
+BOOL __stdcall DllMain(const HMODULE dll_module, const DWORD reason_for_call, void* /*reserved*/) noexcept
 {
     switch (reason_for_call)
     {
     case DLL_PROCESS_ATTACH:
         TRACE("netpbm-wic-codec::DllMain DLL_PROCESS_ATTACH \n");
-        VERIFY(DisableThreadLibraryCalls(module));
+        VERIFY(DisableThreadLibraryCalls(dll_module));
         break;
 
     case DLL_THREAD_ATTACH:

src/util.ixx

@@ -17,11 +17,11 @@ namespace {
 
 [[nodiscard]] HMODULE get_current_module() noexcept
 {
-    HMODULE module;
+    HMODULE current_module;
     GetModuleHandleExW(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT,
-                       reinterpret_cast<PCWSTR>(get_current_module), &module);
+                       reinterpret_cast<PCWSTR>(get_current_module), &current_module);
 
-    return module;
+    return current_module;
 }
 
 } // namespace