Skip to content

Commit f6fb365

Browse files
committed
Remove workaround for HeatWave issue
The new 1.0.5 version of HeatWave has resolved it, remove workaround.
1 parent 600ef6f commit f6fb365

File tree

3 files changed

+1
-15
lines changed

3 files changed

+1
-15
lines changed

Directory.Build.props

+1-9
Original file line numberDiff line numberDiff line change
@@ -69,17 +69,14 @@
6969

7070
<!--
7171
Disable level All warnings that are not useful:
72-
C4061 = enumerator 'identifier' in switch of enum 'enumeration' is not explicitly handled by a case label
7372
C4265 = class has virtual functions, but its non-trivial destructor is not virtual; instances of this class may not be destructed correctly
7473
C4365 = action' : conversion from 'type_1' to 'type_2', signed/unsigned mismatch
75-
C4464 = A #include directive has a path that includes a '..' parent directory specifier. [Just informational]
7674
C4514 = function' : unreferenced inline function has been removed [Just informational]
7775
C4571 = Informational: catch(...) semantics changed since Visual C++ 7.1; structured exceptions (SEH) are no longer caught [Just informational]
7876
C4623 = derived class' : default constructor was implicitly defined as deleted because a base class default constructor is inaccessible or deleted [Just informational]
7977
C4625 = derived class' : copy constructor was implicitly defined as deleted because a base class copy constructor is inaccessible or deleted [Just informational]
8078
C4626 = derived class' : assignment operator was implicitly defined as deleted because a base class assignment operator is inaccessible or deleted [Just informational]
8179
C4668 = symbol' is not defined as a preprocessor macro, replacing with '0' for 'directives' [Just informational]
82-
C4686 = 'std::_Decode_utf': possible change in behavior, change in UDT return calling convention [problem in format in Visual Studio 2022 17.8.0]
8380
C4710 = function '' function not inlined [Just informational]
8481
C4711 = function '' selected for automatic inline expansion [Just informational]
8582
C4738 = storing 32-bit float result in memory, possible loss of performance [Just informational]
@@ -93,12 +90,7 @@
9390
C5204 = '': class has virtual functions, but its trivial destructor is not virtual; instances of objects derived from this class may not be destructed correctly
9491
C5246 = the initialization of a subobject should be wrapped in braces [prevents simple usage of std::byte]
9592
-->
96-
<DisableSpecificWarnings Condition="'$(JPEGLS_WIC_CODEC_ALL_WARNINGS)'!=''">4005;4061;4265;4365;4464;4514;4571;4623;4625;4626;4668;4686;4710;4711;4738;4774;4820;4946;5026;5027;5039;5045;5204;5246</DisableSpecificWarnings>
97-
<!--
98-
C4005 = macro redefinition [Caused by the use of header units]
99-
C4744 = '' has different type [caused by using named module]
100-
-->
101-
<DisableSpecificWarnings>4005;4744;%(DisableSpecificWarnings)</DisableSpecificWarnings>
93+
<DisableSpecificWarnings Condition="'$(JPEGLS_WIC_CODEC_ALL_WARNINGS)'!=''">4265;4365;4514;4571;4623;4625;4626;4668;4710;4711;4738;4774;4820;4946;5026;5027;5039;5045;5204;5246</DisableSpecificWarnings>
10294

10395
<!--
10496
__cplusplus = Tell MSVC to use the correct value for the __cplusplus macro

setup/bootstrapper/bootstrapper.wixproj

-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,4 @@
2727
<Message Importance="high" Text="SignBundle: @(SignBundle)" />
2828
<Exec Command='signtool.exe sign /fd SHA256 /td SHA256 /v /sha1 $(_CertificateThumbprint) /tr $(_TimestampUrl) "%(SignBundle.FullPath)" ' />
2929
</Target>
30-
31-
<!-- Workaround for https://github.com/firegiant/HeatWaveSupport/issues/73 -->
32-
<Target Name="CollectSuggestedVisualStudioComponentIds" />
3330
</Project>

setup/installer/installer.wixproj

-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,4 @@
1818
<Message Importance="high" Text="SignMsi: @(SignMsi)" />
1919
<Exec Command="signtool.exe sign /fd SHA256 /td SHA256 /v /sha1 $(_CertificateThumbprint) /tr $(_TimestampUrl) &quot;%(SignMsi.FullPath)&quot; " />
2020
</Target>
21-
22-
<!-- Workaround for https://github.com/firegiant/HeatWaveSupport/issues/73 -->
23-
<Target Name="CollectSuggestedVisualStudioComponentIds" />
2421
</Project>

0 commit comments

Comments
 (0)