Resolve SonarQube warnings

Author: vbaderks

src/dll_main.cpp

@@ -123,7 +123,7 @@ void register_property_store_file_extension(const wchar_t* file_extension)
                         L"prop:System.ItemType;*System.DateModified;*System.Image.Dimensions;*System.Size");
     registry::set_value(sub_key, L"PreviewDetails",
                         L"prop:*System.DateModified;*System.Image.Dimensions;*System.Size;*System.OfflineAvailability;"
-                        "*System.OfflineStatus;*System.DateCreated;*System.SharedWith");
+                        L"*System.OfflineStatus;*System.DateCreated;*System.SharedWith");
 }
 
 void register_property_store()

src/jpegls-wic-codec.vcxproj

@@ -72,6 +72,7 @@
     </Link>
   </ItemDefinitionGroup>
   <ItemGroup>
+    <ClInclude Include="intellisense.hpp" />
     <ClInclude Include="macros.hpp" />
     <ClInclude Include="version.hpp" />
   </ItemGroup>

src/jpegls-wic-codec.vcxproj.filters

@@ -21,6 +21,9 @@
     <ClInclude Include="macros.hpp">
       <Filter>Header Files</Filter>
     </ClInclude>
+    <ClInclude Include="intellisense.hpp">
+      <Filter>Header Files</Filter>
+    </ClInclude>
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="dll_main.cpp">

src/jpegls_bitmap_frame_decode.cpp

@@ -156,8 +156,9 @@ uint32_t compute_minimal_stride(const frame_info& frame_info) noexcept
 void shift_samples(void* buffer, const size_t pixel_count, const uint32_t sample_shift)
 {
     auto* const pixels{static_cast<uint16_t*>(buffer)};
-    std::transform(pixels, pixels + pixel_count, pixels,
-                   [sample_shift](const uint16_t pixel) -> uint16_t { return pixel << sample_shift; });
+    std::transform(pixels, pixels + pixel_count, pixels, [sample_shift](const uint16_t pixel) {
+        return static_cast<uint16_t>(pixel << sample_shift);
+    });
 }
 
 template<typename SizeType>
@@ -195,17 +196,18 @@ void set_resolution(const jpegls_decoder& decoder, IWICBitmap& bitmap)
         {
             switch (spiff_header.resolution_units)
             {
-            case spiff_resolution_units::aspect_ratio:
+                using enum spiff_resolution_units;
+            case aspect_ratio:
                 break;
 
-            case spiff_resolution_units::dots_per_centimeter: {
+            case dots_per_centimeter: {
                 constexpr double dpc_to_dpi{2.54};
                 check_hresult(bitmap.SetResolution(std::round(spiff_header.horizontal_resolution * dpc_to_dpi),
                                                    std::round(spiff_header.vertical_resolution * dpc_to_dpi)));
                 return;
             }
 
-            case spiff_resolution_units::dots_per_inch:
+            case dots_per_inch:
                 check_hresult(bitmap.SetResolution(spiff_header.horizontal_resolution, spiff_header.vertical_resolution));
                 return;
             }

src/jpegls_bitmap_frame_encode.cpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: © 2023 Team CharLS
+// SPDX-FileCopyrightText: © 2023 Team CharLS
 // SPDX-License-Identifier: BSD-3-Clause
 
 module;
@@ -199,7 +199,7 @@ try
 
     allocate_pixel_buffer();
 
-    winrt::check_hresult(bitmap_source->CopyPixels(nullptr, static_cast<uint32_t>(source_stride_), static_cast<uint32_t>(source_.size()),
+    winrt::check_hresult(bitmap_source->CopyPixels(nullptr, source_stride_, static_cast<uint32_t>(source_.size()),
                                                    reinterpret_cast<BYTE*>(source_.data())));
     state_ = state::received_pixels;
     return success_ok;

src/jpegls_bitmap_frame_encode.ixx

@@ -1,6 +1,10 @@
-// SPDX-FileCopyrightText: © 2019 Team CharLS
+// SPDX-FileCopyrightText: © 2019 Team CharLS
 // SPDX-License-Identifier: BSD-3-Clause
 
+module;
+
+#include "intellisense.hpp"
+
 export module jpegls_bitmap_frame_encode;
 
 import std;