Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for capacitor v7 #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JavierMartinz
Copy link

@JavierMartinz JavierMartinz commented Feb 4, 2025

closes #96

Copy link

@wJoenn wJoenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, you can remove the entries of .prettierignore that are already in .gitignore as from Prettier 3.0.0, it ignores files in .gitignore file by default. If all the entries of .prettierignore are already in .gitignore, you can remove the .prettierignore file entirely.

You can remove the .prettierignore file completely as both directories are already ignored in .gitignore


Were the android/gradle/wrapper/graddle-wrapper.jar, android/gradlew and android/gradlew.bat files updated automatically by running npx @capacitor/plugin-migration-v6-to-v7@latest ?

If not, can you elaborate on why you applied these changes ?

@JavierMartinz
Copy link
Author

JavierMartinz commented Feb 5, 2025

Yes, it was @capacitor/plugin-migration-v6-to-v7@latest. I didn't do anything else

@kstruempf
Copy link

You might also need to upgrade to CI pipeline to use Java version 21

File: .github/workflows/ci.yml

      - name: set up JDK 17
        uses: actions/setup-java@v4
        with:
          java-version: '17'
          distribution: 'zulu'

should become

      - name: set up JDK 21
        uses: actions/setup-java@v4
        with:
          java-version: '21'
          distribution: 'zulu'

@wJoenn
Copy link

wJoenn commented Feb 6, 2025

You should update the README too

| 6.* | 6 | master |

 | 7.*            | 7                 | master | 

I think you can remove the Branch column as well considering only the master branch still exist

@shyamal890
Copy link

Looking forward to this getting released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Capacitor 7 support
4 participants