-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for capacitor v7 #97
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, you can remove the entries of .prettierignore that are already in .gitignore as from Prettier 3.0.0, it ignores files in .gitignore file by default. If all the entries of .prettierignore are already in .gitignore, you can remove the .prettierignore file entirely.
You can remove the .prettierignore
file completely as both directories are already ignored in .gitignore
Were the android/gradle/wrapper/graddle-wrapper.jar
, android/gradlew
and android/gradlew.bat
files updated automatically by running npx @capacitor/plugin-migration-v6-to-v7@latest
?
If not, can you elaborate on why you applied these changes ?
Yes, it was @capacitor/plugin-migration-v6-to-v7@latest. I didn't do anything else |
You might also need to upgrade to CI pipeline to use Java version 21 File: .github/workflows/ci.yml
should become
|
You should update the README too capacitor-voice-recorder/README.md Line 243 in 874b84e
| 7.* | 7 | master | I think you can remove the |
Looking forward to this getting released |
closes #96