wildcardExports naming change

[guybedford]

This changes ModuleSource.prototype.starExports() to instead be referred to as ModuleSource.prototype.wildcardExports(), since the term "star exports" is currently only an internal spec naming, which is not used outside of the spec itself.

[Jack-Works]

Suggested change

	### `AbstractModuleSource.prototype.namespaceReexports()`
	### `AbstractModuleSource.prototype.namespaceReExports()`

what about?

[Jack-Works]

or, reExportAlls()?

[guybedford]

I always wonder about the camelcasing of reexports too. Strictly speaking, isn't the prefix part of the same word though?

[Jack-Works]

excepts camel casing, namespace reexports makes me think of export * as ns from ...

[guybedford]

That's a good point. Maybe namespacedExports or namespacedReexports with a d could help disambiguate?

[Jack-Works]

What do you think? cc @nicolo-ribaudo

[ljharb]

export * as ns from would still be in this list, though, no? since it's statically creating an ns named export?

[Jack-Works]

export * as ns from would still be in this list, though, no? since it's statically creating an ns named export?

No, I think? It only refers to all specifiers from export * from.

export * as x from 'x'
export * from 'y'

only "y" appears in this list

[Jack-Works]

by the way, I don't know if these two have observable differences in the language.

export * as x from 'x'

import * as <unique identifier> from 'x'
export { <unique identifier> as x }

[ljharb]

To be honest i think "star" being inside the spec is irrelevant - the reason that name makes the most sense is because it uses a *, which is a "star".

[guybedford]

Another name that we could use here is "barrel export". So we could call the method barrelExports().

In references I've found it's commonly used to refer directly to export * from. For example, https://basarat.gitbook.io/typescript/main-1/barrel.

[Jack-Works]

Another name that we could use here is "barrel export". So we could call the method barrelExports().

In references I've found it's commonly used to refer directly to export * from. For example, basarat.gitbook.io/typescript/main-1/barrel.

In my understanding, "barrel" is used to refer to the file that only contains a list of export statements.

If a file looks like this:

export function a() {
    // a lot of logic
}
export function b() {
    // a lot of logic
}
// ....
export * from './constants.js'

I won't call it a "barrel" export

[guybedford]

Another name we might use that is used on MDN is the term "wildcard export", so wildcardExports as the function.

[guybedford]

I've updated this PR to use the term wildcardExports.