Skip to content

Commit

Permalink
ethercatmcAxis.cpp: Not homed sets no longer the problem bit
Browse files Browse the repository at this point in the history
"Old" versions of the for ess-motorRecord did treat the "problem" bit
not as indicator, the the motor has stopped.
Later versions do.
This makes the DMOV bit toggle twice when a not homed motor is homed.

The alarm handling (for a not homed motor) is now done via setting
motorNotHomedProblem_ to 1.

In other words: It is time to remove this handling:
eeAxisError = eeAxisErrorNotHomed
  • Loading branch information
tboegi committed Sep 26, 2024
1 parent 3e569e9 commit 4483d7c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions ethercatmcApp/src/ethercatmcAxis.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -882,10 +882,6 @@ void ethercatmcAxis::callParamCallbacksUpdateError() {
} else if (drvlocal.cmdErrorMessage[0]) {
drvlocal.eeAxisError = eeAxisErrorCmdError;
msgTxtFromDriver = &drvlocal.cmdErrorMessage[0];
#ifndef motorNotHomedProblemString
} else if (!drvlocal.homed && (drvlocal.nCommandActive != NCOMMANDHOME)) {
drvlocal.eeAxisError = eeAxisErrorNotHomed;
#endif
} else if (drvlocal.illegalInTargetWindow) {
drvlocal.eeAxisError = eeAxisIllegalInTargetWindow;
msgTxtFromDriver = "E: InTargetPosWin";
Expand Down
1 change: 0 additions & 1 deletion ethercatmcApp/src/ethercatmcAxis.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ class epicsShareClass ethercatmcAxis : public asynMotorAxis {
eeAxisErrorMCUError,
eeAxisErrorCmdError,
eeAxisErrorNotFound,
eeAxisErrorNotHomed,
eeAxisIllegalInTargetWindow
} eeAxisErrorType;

Expand Down

0 comments on commit 4483d7c

Please sign in to comment.