parse: Reject integers that start with whitespace

tavianator · Dec 9, 2023 · e0d7dc5 · e0d7dc5
1 parent deb293c
commit e0d7dc5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/parse.c b/src/parse.c
@@ -565,13 +565,17 @@ enum int_flags {
  * Parse an integer.
  */
 static const char *parse_int(const struct parser_state *state, char **arg, const char *str, void *result, enum int_flags flags) {
-	char *endptr;
+	// strtoll() skips leading spaces, but we want to reject them
+	if (xisspace(str[0])) {
+		goto bad;
+	}
 
 	int base = flags & IF_BASE_MASK;
 	if (base == 0) {
 		base = 10;
 	}
 
+	char *endptr;
 	errno = 0;
 	long long value = strtoll(str, &endptr, base);
 	if (errno != 0) {

diff --git a/tests/bfs/links_leading_space.sh b/tests/bfs/links_leading_space.sh
@@ -0,0 +1 @@
+! invoke_bfs links -links ' 1'