This repository has been archived by the owner on Feb 20, 2020. It is now read-only.
add a 'dep check' run to CI #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See golang/dep#1990 - this is basically a silly thing that getsentry is doing that is causing issues with go dep in a way that go dep can't really handle.
|
I also filed getsentry/raven-go#243 |
petemoore
reviewed
Mar 8, 2019
| image: golang:1.10 | ||
| env: | ||
| # once bug 1508383 is landed, this won't be required (the worker will supply it) | ||
| TASKCLUSTER_ROOT_URL: https://taskcluster.net |
There was a problem hiding this comment.
I think this isn't needed as bug 1508383 has landed, but I'll remove it in a separate PR as we have that throughout the .taskcluster.yml file.
There was a problem hiding this comment.
It is still needed for generic-worker workers that have not been upgraded to ^13.0.0
petemoore
approved these changes
Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.