refactor: port cucumber tests to rs #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2022
CjS77
added
CR-too_long
fix: fixing broken base node in the feature-cucumber-rs branch
…ration chore: separate integration test run
fix: cucumber base node lock issue
feat: add shutdown clone
feat: wallet FFI cucumber
feat: add steps for wallet cli feature
# Conflicts: # base_layer/core/src/validation/header_iter.rs # base_layer/core/src/validation/helpers.rs
test: merge mining cucumber
stringhandler
approved these changes
Jan 21, 2023
| @@ -136,7 +136,7 @@ impl EmissionSchedule { | |||
| let mut carry_last = 0u8; | |||
| for i in 0..len { | |||
| let index = len - 1 - i; | |||
| let carry = if num[index] >= 5 { 1 } else { 0 }; | |||
| let carry = (num[index] >= 5).into(); | |||
There was a problem hiding this comment.
Not a fan of this. I think a clippy allow would be clearer
| @@ -224,8 +224,8 @@ pub fn create_merkle_proof(hashes: &[Hash], hash: &Hash) -> Option<MerkleProof> | |||
| if h != hash { | |||
| return None; | |||
| } | |||
| let i = if pos == 0 { 1 } else { 0 }; | |||
| MerkleProof::try_construct(vec![hashes[i]], 1, if pos == 0 { 0 } else { 1 }) | |||
| let i = usize::from(pos == 0); | |||
There was a problem hiding this comment.
Also not a fan here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a Base feature branch that all additional work on the implementation will be merged into, before being merged into development.
Motivation and Context
Removing the JS dependencies in favor of a pure rust implementation
Related
Toolchain upgrade:
tari-labs/docker#23
tari-project/action-buildlibs#10
How Has This Been Tested?
CI
Closes: #5050