Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert javascript cucumber tests to rust #4963

Closed
stringhandler opened this issue Nov 28, 2022 · 2 comments
Closed

Convert javascript cucumber tests to rust #4963

stringhandler opened this issue Nov 28, 2022 · 2 comments
Assignees
@agubarev
Labels
A-base_node Area - The Tari base node executable and libraries A-ci Area - Continuous Integration related C-tech_debt tidies up technical debt

Comments

@stringhandler
Copy link
Collaborator

The javascript cucumber tests have served us well, but given the improvements done in the tari-dan project that runs tests using rust cucumber, it will be easier to refactor and find duplicate code in the rust tests than in the javascript
@stringhandler stringhandler added C-tech_debt tidies up technical debt A-base_node Area - The Tari base node executable and libraries A-ci Area - Continuous Integration related labels Nov 28, 2022
@stringhandler stringhandler moved this to Selected for development in Tari Esme Testnet Nov 28, 2022
@jorgeantonio21
Copy link
Contributor

Really happy to see this happen !

@stringhandler stringhandler mentioned this issue Nov 30, 2022
Open
@agubarev agubarev self-assigned this Nov 30, 2022
@agubarev agubarev moved this from Selected for development to In Progress in Tari Esme Testnet Dec 2, 2022
@stringhandler stringhandler moved this from In Progress to Selected for development in Tari Esme Testnet Feb 2, 2023
@stringhandler stringhandler moved this from Selected for development to In Review in Tari Esme Testnet Feb 15, 2023
@SWvheerden
Copy link
Collaborator

fixed in #5051

@github-project-automation github-project-automation bot moved this from In Review to Done in Tari Esme Testnet Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agubarev agubarev

Labels
A-base_node Area - The Tari base node executable and libraries A-ci Area - Continuous Integration related C-tech_debt tidies up technical debt
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@agubarev @SWvheerden @stringhandler @jorgeantonio21