Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change deprecated JSX namespace to React.JSX #3435 #4226

Closed
wants to merge 1 commit into from
Closed

change deprecated JSX namespace to React.JSX #3435 #4226

wants to merge 1 commit into from

Conversation

dhruvdankhara
Copy link

@dhruvdankhara dhruvdankhara commented Dec 26, 2024 •
edited
Loading

  • Identified the issue
    This pull request includes changes to update the return type of several React components from JSX.Element to React.JSX.Element. This is a minor but widespread update across multiple files to ensure consistency and potentially leverage newer TypeScript features.

The most important changes include:
chnge deprecated JSX namespace to React.JSX

  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhruvdankhara